Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932896AbaFIWZk (ORCPT ); Mon, 9 Jun 2014 18:25:40 -0400 Received: from mail-vc0-f178.google.com ([209.85.220.178]:49009 "EHLO mail-vc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932402AbaFIWZh (ORCPT ); Mon, 9 Jun 2014 18:25:37 -0400 MIME-Version: 1.0 In-Reply-To: <20140503221658.GA13403@kroah.com> References: <1397859600-11507-1-git-send-email-robherring2@gmail.com> <1397859600-11507-4-git-send-email-robherring2@gmail.com> <20140503220731.GA10927@kroah.com> <20140503221658.GA13403@kroah.com> Date: Mon, 9 Jun 2014 15:25:37 -0700 Message-ID: Subject: Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon From: Tony Luck To: Greg Kroah-Hartman Cc: Rob Herring , Yinghai Lu , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , "linux-serial@vger.kernel.org" , Jiri Slaby , Catalin Marinas , Russell King , Will Deacon , Arnd Bergmann , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 3, 2014 at 3:16 PM, Greg Kroah-Hartman wrote: >> > >> drivers/tty/serial/8250/8250_early.c | 138 ++++------------------------------- >> > >> drivers/tty/serial/8250/Kconfig | 1 + >> > >> 2 files changed, 16 insertions(+), 123 deletions(-) >> > > >> > > Hi Greg, Rob >> > > >> > > This one in tty-next breaks booting: "console=uart8250,io,0x3f8,115200". >> > > No early console and regular console anymore. >> > > >> > > It should produce "early con and regular con". >> > >> > This is what I get for running checkpatch and converting >> > simple_strtoul to kstrto* which are not so equivalent. kstrto* will >> > not convert things such as 115200n8 to a number. >> > >> > Greg, Do you want a fix or for me to respin the series? The fix looks like this: >> >> As this is in my tree now (right?), I need a fix to apply to it. > > Nevermind, you already sent it... Linus' tree (HEAD=963649d735c8) is spitting out all sorts of garbage on the serial console - as if the baud rate is being periodically set to something weird, and then back to 112500. I see over a dozen blocks of junk interspersed with good output. This in on ia64 with "console=uart,io,0x3f8" on the command line. git bisect pointed me here: d2fd6810a823bcde1ee232668f5689837aafa772 is first bad commit commit d2fd6810a823bcde1ee232668f5689837aafa772 Author: Rob Herring Date: Fri Apr 18 17:19:56 2014 -0500 tty/serial: convert 8250 to generic earlycon -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/