Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933934AbaFJCpX (ORCPT ); Mon, 9 Jun 2014 22:45:23 -0400 Received: from lgeamrelo04.lge.com ([156.147.1.127]:43192 "EHLO lgeamrelo04.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754382AbaFJCpW (ORCPT ); Mon, 9 Jun 2014 22:45:22 -0400 X-Original-SENDERIP: 10.177.220.145 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Tue, 10 Jun 2014 11:49:11 +0900 From: Joonsoo Kim To: Michal Nazarewicz Cc: Andrew Morton , "Aneesh Kumar K.V" , Marek Szyprowski , Minchan Kim , Russell King - ARM Linux , Greg Kroah-Hartman , Paolo Bonzini , Gleb Natapov , Alexander Graf , Benjamin Herrenschmidt , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH 2/3] DMA, CMA: use general CMA reserved area management framework Message-ID: <20140610024910.GB19036@js1304-P5Q-DELUXE> References: <1401757919-30018-1-git-send-email-iamjoonsoo.kim@lge.com> <1401757919-30018-3-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 03, 2014 at 09:00:48AM +0200, Michal Nazarewicz wrote: > On Tue, Jun 03 2014, Joonsoo Kim wrote: > > Now, we have general CMA reserved area management framework, > > so use it for future maintainabilty. There is no functional change. > > > > Signed-off-by: Joonsoo Kim > > Acked-by: Michal Nazarewicz > > > diff --git a/include/linux/dma-contiguous.h b/include/linux/dma-contiguous.h > > index dfb1dc9..ecb85ac 100644 > > --- a/include/linux/dma-contiguous.h > > +++ b/include/linux/dma-contiguous.h > > @@ -53,9 +53,10 @@ > > > > #ifdef __KERNEL__ > > > > +#include > > + > > Why is this suddenly required? > > > struct cma; > > struct page; > > -struct device; > > > > #ifdef CONFIG_DMA_CMA > Without including device.h, build failure occurs. In dma-contiguous.h, we try to access to dev->cma_area, so we need device.h. In the past, we included it luckily by swap.h in drivers/base/dma-contiguous.c. Swap.h includes node.h and then node.h includes device.h, so we were happy. But, in this patch, I remove 'include ' so we need to include device.h explicitly. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/