Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754988AbaFJFVv (ORCPT ); Tue, 10 Jun 2014 01:21:51 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:54242 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbaFJFVu (ORCPT ); Tue, 10 Jun 2014 01:21:50 -0400 MIME-Version: 1.0 In-Reply-To: <53962059.6070306@semaphore.gr> References: <53962059.6070306@semaphore.gr> Date: Tue, 10 Jun 2014 10:51:49 +0530 Message-ID: Subject: Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check From: Viresh Kumar To: Stratos Karafotis Cc: "Rafael J. Wysocki" , Dirk Brandewie , "linux-pm@vger.kernel.org" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10 June 2014 02:30, Stratos Karafotis wrote: > We check the CPU ID during driver init. There is no need > to do it again per logical CPU initialization. > > So, remove the duplicate check. > > Signed-off-by: Stratos Karafotis > --- > drivers/cpufreq/intel_pstate.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index aebd457..4e7f492 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids); > > static int intel_pstate_init_cpu(unsigned int cpunum) > { > - > - const struct x86_cpu_id *id; > struct cpudata *cpu; > > - id = x86_match_cpu(intel_pstate_cpu_ids); > - if (!id) > - return -ENODEV; > - > all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL); > if (!all_cpu_data[cpunum]) > return -ENOMEM; Acked-by: Viresh Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/