Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbaFJPOS (ORCPT ); Tue, 10 Jun 2014 11:14:18 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:60808 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750843AbaFJPOP (ORCPT ); Tue, 10 Jun 2014 11:14:15 -0400 From: "Rafael J. Wysocki" To: Dirk Brandewie Cc: Stratos Karafotis , Viresh Kumar , dirk.j.brandewie@intel.com, "linux-pm@vger.kernel.org" , LKML Subject: Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup Date: Tue, 10 Jun 2014 17:31:38 +0200 Message-ID: <1447217.dTmMAkaUnF@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <53972070.3020608@intel.com> References: <5396208F.6070400@semaphore.gr> <53972070.3020608@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: > On 06/09/2014 02:01 PM, Stratos Karafotis wrote: > > Remove unnecessary blank lines. > > Remove unnecessary parentheses. > > Remove unnecessary braces. > > Put the code in one line where possible. > > Add blank lines after variable declarations. > > Alignment to open parenthesis. > > > > I don't have an issue with this patch in general but I would rather > the cleanup be done when there is a functional change in the given > hunk of code otherwise you are setting up a fence for stable/backporters > of functional changes in the future. I actually prefer separate cleanups so as to avoid doing multiple things in one patch. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/