Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbaFJPQ6 (ORCPT ); Tue, 10 Jun 2014 11:16:58 -0400 Received: from service87.mimecast.com ([91.220.42.44]:45460 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbaFJPQz convert rfc822-to-8bit (ORCPT ); Tue, 10 Jun 2014 11:16:55 -0400 From: "Javi Merino" Date: Tue, 10 Jun 2014 16:16:49 +0100 To: Jacob Pan , Zhang Rui Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: [PATCH] tools/thermal: tmon: fix compilation errors when building statically Message-ID: <20140610151649.GB2798@e104805> References: <1401728897-25188-1-git-send-email-javi.merino@arm.com> <20140602045457.6b519e43@jacob-desktop> MIME-Version: 1.0 In-Reply-To: <20140602045457.6b519e43@jacob-desktop> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginalArrivalTime: 10 Jun 2014 15:16:45.0440 (UTC) FILETIME=[FDD6D000:01CF84BE] X-MC-Unique: 114061016165306301 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rui, On Mon, Jun 02, 2014 at 12:54:57PM +0100, Jacob Pan wrote: > On Mon, 2 Jun 2014 18:08:17 +0100 > "Javi Merino" wrote: > > > tmon fails to build statically with the following error: > > > > $ make LDFLAGS=-static > > gcc -O1 -Wall -Wshadow -W -Wformat -Wimplicit-function-declaration > > -Wimplicit-int -fstack-protector -D VERSION=\"1.0\" -static tmon.o > > tui.o sysfs.o pid.o -o tmon -lm -lpanel -lncursesw -lpthread > > tmon.o: In function `tmon_sig_handler': tmon.c:(.text+0x21): > > undefined reference to `stdscr' tmon.o: In function `tmon_cleanup': > > tmon.c:(.text+0xb9): undefined reference to `stdscr' > > tmon.c:(.text+0x11e): undefined reference to `stdscr' > > tmon.c:(.text+0x123): undefined reference to `keypad' > > tmon.c:(.text+0x12d): undefined reference to `nocbreak' tmon.o: In > > function `main': tmon.c:(.text+0x785): undefined reference to `stdscr' > > tmon.c:(.text+0x78a): undefined reference to `nodelay' > > tui.o: In function `setup_windows': > > tui.c:(.text+0x131): undefined reference to `stdscr' > > tui.c:(.text+0x176): undefined reference to `stdscr' > > tui.c:(.text+0x19f): undefined reference to `stdscr' > > tui.c:(.text+0x1cc): undefined reference to `stdscr' > > tui.c:(.text+0x1ff): undefined reference to `stdscr' > > tui.o:tui.c:(.text+0x229): more undefined references to `stdscr' > > follow tui.o: In function `show_cooling_device': > > [...] > > > > stdscr() and friends are in libtinfo (part of ncurses) so add it to > > the libraries that are linked in when compiling tmon to fix it. > > > Acked-by: Jacob Pan Thanks! Rui, can you pick this up? Cheers, Javi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/