Date: Tue, 10 Jun 2014 13:51:25 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Brad Mouring <bmouring@ni.com>, LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Lai Jiangshan <laijs@cn.fujitsu.com>, Jason Low <jason.low2@hp.com>
Subject: Re: [patch V3 7/7] rtmutex: Avoid pointless requeueing in the
 deadlock detection chain walk
Message-ID: <20140610135125.2a9190ec@gandalf.local.home>
In-Reply-To: <alpine.DEB.2.10.1406101943000.5170@nanos>
References: <20140609201118.387571774@linutronix.de>
	<20140609202336.506044876@linutronix.de>
	<20140610145725.GA29976@linuxgetsreal>
	<20140610111942.668d4058@gandalf.local.home>
	<alpine.DEB.2.10.1406101943000.5170@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 10 Jun 2014 19:43:16 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Tue, 10 Jun 2014, Steven Rostedt wrote:
> 
> > On Tue, 10 Jun 2014 09:57:25 -0500
> > "Brad Mouring" <bmouring@ni.com> wrote:
> > 
> > 
> > > > +		/* Store whether owner is blocked itself and drop locks */
> > > > +		next_lock = task_blocked_on(task);
> > > task_blocked_on(task) is not clear to me, the recipient of the
> > > return is the only clue that hints at what the function does.
> > 
> > Well, this is more than confusing, it's the only user, all other users
> > are task_blocked_on_lock(), and this causes the code not to compile.
> 
> Grr, yes.

Luckily you are not posting this to that grumpy IRQ maintainer. He'd
shoot some frozen sharks your way if you sent him patches like this ;-)

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/