Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754412AbaFJUqU (ORCPT ); Tue, 10 Jun 2014 16:46:20 -0400 Received: from www.linutronix.de ([62.245.132.108]:55351 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753259AbaFJUqT (ORCPT ); Tue, 10 Jun 2014 16:46:19 -0400 Date: Tue, 10 Jun 2014 22:46:14 +0200 (CEST) From: Thomas Gleixner To: Steven Rostedt cc: Brad Mouring , LKML , Peter Zijlstra , Ingo Molnar , Lai Jiangshan , Jason Low Subject: Re: [patch V3 7/7] rtmutex: Avoid pointless requeueing in the deadlock detection chain walk In-Reply-To: <20140610135125.2a9190ec@gandalf.local.home> Message-ID: References: <20140609201118.387571774@linutronix.de> <20140609202336.506044876@linutronix.de> <20140610145725.GA29976@linuxgetsreal> <20140610111942.668d4058@gandalf.local.home> <20140610135125.2a9190ec@gandalf.local.home> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jun 2014, Steven Rostedt wrote: > On Tue, 10 Jun 2014 19:43:16 +0200 (CEST) > Thomas Gleixner wrote: > > > On Tue, 10 Jun 2014, Steven Rostedt wrote: > > > > > On Tue, 10 Jun 2014 09:57:25 -0500 > > > "Brad Mouring" wrote: > > > > > > > > > > > + /* Store whether owner is blocked itself and drop locks */ > > > > > + next_lock = task_blocked_on(task); > > > > task_blocked_on(task) is not clear to me, the recipient of the > > > > return is the only clue that hints at what the function does. > > > > > > Well, this is more than confusing, it's the only user, all other users > > > are task_blocked_on_lock(), and this causes the code not to compile. > > > > Grr, yes. > > Luckily you are not posting this to that grumpy IRQ maintainer. He'd > shoot some frozen sharks your way if you sent him patches like this ;-) Rightfully so. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/