Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbaFJVK6 (ORCPT ); Tue, 10 Jun 2014 17:10:58 -0400 Received: from mail-qa0-f53.google.com ([209.85.216.53]:58653 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbaFJVK4 (ORCPT ); Tue, 10 Jun 2014 17:10:56 -0400 MIME-Version: 1.0 In-Reply-To: <20140609114222.GC9307@localhost> References: <1402003746-6354-1-git-send-email-janne.kanniainen@gmail.com> <20140606094752.GB9307@localhost> <20140609114222.GC9307@localhost> Date: Wed, 11 Jun 2014 00:10:55 +0300 Message-ID: Subject: Re: [PATCH v2] leds: USB: Add support for MSI GT683R led panels From: Janne Kanniainen To: Johan Hovold Cc: Bryan Wu , rpurdie@rpsys.net, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-usb@vger.kernel.org, Jiri Kosina , linux-input@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> > Where did you get these (HID report) values from by the way? >> >> I got them by reverse engineering. > > Traffic sniffing? > Yes. > In fact, it seems you can get away with not adding any locking here. > Just do the (mutex) locking in gt683r_led_set (or gt683r_led_work). Ok I will fix it. Janne -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/