Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754230AbaFKAPT (ORCPT ); Tue, 10 Jun 2014 20:15:19 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:62147 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752183AbaFKAPR (ORCPT ); Tue, 10 Jun 2014 20:15:17 -0400 From: "Rafael J. Wysocki" To: Stratos Karafotis Cc: Dirk Brandewie , Viresh Kumar , dirk.j.brandewie@intel.com, "linux-pm@vger.kernel.org" , LKML Subject: Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check Date: Wed, 11 Jun 2014 02:32:41 +0200 Message-ID: <3882689.ERRzduavD8@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <53973CF5.4000201@intel.com> References: <53962059.6070306@semaphore.gr> <53973CF5.4000201@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 10, 2014 10:14:29 AM Dirk Brandewie wrote: > On 06/09/2014 10:21 PM, Viresh Kumar wrote: > > On 10 June 2014 02:30, Stratos Karafotis wrote: > >> We check the CPU ID during driver init. There is no need > >> to do it again per logical CPU initialization. > >> > >> So, remove the duplicate check. > >> > >> Signed-off-by: Stratos Karafotis > >> --- > >> drivers/cpufreq/intel_pstate.c | 6 ------ > >> 1 file changed, 6 deletions(-) > >> > >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > >> index aebd457..4e7f492 100644 > >> --- a/drivers/cpufreq/intel_pstate.c > >> +++ b/drivers/cpufreq/intel_pstate.c > >> @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids); > >> > >> static int intel_pstate_init_cpu(unsigned int cpunum) > >> { > >> - > >> - const struct x86_cpu_id *id; > >> struct cpudata *cpu; > >> > >> - id = x86_match_cpu(intel_pstate_cpu_ids); > >> - if (!id) > >> - return -ENODEV; > >> - > >> all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL); > >> if (!all_cpu_data[cpunum]) > >> return -ENOMEM; > > > > Acked-by: Viresh Kumar > > > Acked-by: Dirk Brandewie [1/7] applied, please wait with the rest until after 3.16-rc1 is released. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/