Message-ID: <1402455034.2719.3.camel@joe-AO725>
Subject: Re: [PATCH] x86/tlb_uv: Fixing some memory allocation failure in
 x86 UV
From: Joe Perches <joe@perches.com>
To: Zhouyi Zhou <zhouzhouyi@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        mingo@redhat.com, x86@kernel.org,
        Peter Zijlstra <peterz@infradead.org>, cpw@sgi.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Zhouyi Zhou <yizhouzhou@ict.ac.cn>
Date: Tue, 10 Jun 2014 19:50:34 -0700
In-Reply-To: <CAABZP2xD4zRX78HxK1DB+13s+1bo=Ai2x+uJDhtJjb+nkZ7epQ@mail.gmail.com>
References: <1402385723-23138-1-git-send-email-zhouzhouyi@gmail.com>
	 <53978E9F.1010003@zytor.com> <alpine.DEB.2.10.1406110111300.5170@nanos>
	 <CAABZP2xD4zRX78HxK1DB+13s+1bo=Ai2x+uJDhtJjb+nkZ7epQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Wed, 2014-06-11 at 09:46 +0800, Zhouyi Zhou wrote:
> Thanks for reviewing, I will work on a new version

If you do, please remove the "out of memory" messages.

These messages are redundant to a generic OOM and
stack dump from the memory subsystem.

Less code is also makes it less likely to have an OOM.

btw: I added a new checkpatch test based on your patch.

https://lkml.org/lkml/2014/6/10/382


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/