Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932341AbaFKNYH (ORCPT ); Wed, 11 Jun 2014 09:24:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44410 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932143AbaFKNYE (ORCPT ); Wed, 11 Jun 2014 09:24:04 -0400 Date: Wed, 11 Jun 2014 09:23:37 -0400 From: Luiz Capitulino To: Yinghai Lu Cc: Christoph Lameter , Tejun Heo , Andrew Morton , Andi Kleen , Rik van Riel , Yasuaki Ishimatsu , Linux MM , Linux Kernel Mailing List , "stable@vger.kernel.org" Subject: Re: [PATCH] x86: numa: drop ZONE_ALIGN Message-ID: <20140611092337.35794bc0@redhat.com> In-Reply-To: References: <20140608181436.17de69ac@redhat.com> <20140609150353.75eff02b@redhat.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yinghai, sorry for my late reply. On Mon, 9 Jun 2014 15:13:41 -0700 Yinghai Lu wrote: > On Mon, Jun 9, 2014 at 12:03 PM, Luiz Capitulino wrote: > > On Sun, 8 Jun 2014 18:29:11 -0700 > > Yinghai Lu wrote: > > > >> On Sun, Jun 8, 2014 at 3:14 PM, Luiz Capitulino wrote: > > [ 0.000000] e820: BIOS-provided physical RAM map: > > [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable > > [ 0.000000] BIOS-e820: [mem 0x000000000009fc00-0x000000000009ffff] reserved > > [ 0.000000] BIOS-e820: [mem 0x00000000000e0000-0x00000000000fffff] reserved > > [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x000000003ffeffff] usable > > [ 0.000000] BIOS-e820: [mem 0x000000003fff0000-0x000000003fffefff] ACPI data > > [ 0.000000] BIOS-e820: [mem 0x000000003ffff000-0x000000003fffffff] ACPI NVS > > [ 0.000000] BIOS-e820: [mem 0x0000000040200000-0x00000000801fffff] usable > ... > > [ 0.000000] SRAT: PXM 0 -> APIC 0x00 -> Node 0 > > [ 0.000000] SRAT: PXM 0 -> APIC 0x01 -> Node 0 > > [ 0.000000] SRAT: PXM 1 -> APIC 0x02 -> Node 1 > > [ 0.000000] SRAT: PXM 1 -> APIC 0x03 -> Node 1 > > [ 0.000000] SRAT: Node 0 PXM 0 [mem 0x00000000-0x3fffffff] > > [ 0.000000] SRAT: Node 1 PXM 1 [mem 0x40200000-0x801fffff] > > [ 0.000000] Initmem setup node 0 [mem 0x00000000-0x3fffffff] > > [ 0.000000] NODE_DATA [mem 0x3ffec000-0x3ffeffff] > > [ 0.000000] Initmem setup node 1 [mem 0x40800000-0x801fffff] > > [ 0.000000] NODE_DATA [mem 0x801fb000-0x801fefff] > > so node1 start is aligned to 8M from 2M > > node0: [0, 1G) > node1: [1G+2M, 2G+2M) > > The zone should not cross the 8M boundary? Yes, but the question is: why? > In the case should we trim the memblock for numa to be 8M alignment ? My current thinking, after discussing this with David, is to just page align the memory range. This should fix the hyperv-triggered bug in 2.6.32 and seems to be the right thing for upstream too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/