Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755817AbaFKPUc (ORCPT ); Wed, 11 Jun 2014 11:20:32 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:51727 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752568AbaFKPUa (ORCPT ); Wed, 11 Jun 2014 11:20:30 -0400 MIME-Version: 1.0 In-Reply-To: <5398732E.2060900@zytor.com> References: <5398732E.2060900@zytor.com> Date: Wed, 11 Jun 2014 11:20:30 -0400 X-Google-Sender-Auth: AchHiDev9lmNcux-jgpJYfl-OUk Message-ID: Subject: Re: vdso_install target broken post-3.15 From: Josh Boyer To: "H. Peter Anvin" Cc: Andy Lutomirski , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 11, 2014 at 11:18 AM, H. Peter Anvin wrote: > On 06/11/2014 08:16 AM, Josh Boyer wrote: >> On Wed, Jun 11, 2014 at 10:14 AM, Josh Boyer wrote: >>> Hi, >>> >>> I'm guessing commit 6f121e548f83674ab4920a4e60afb58d4f61b829 is what >>> broke the vdso_install target: >>> >>> + make -s ARCH=x86_64 >>> INSTALL_MOD_PATH=/home/jwboyer/rpmbuild/BUILDROOT/kernel-3.16.0-0.rc0.git1.1.fc21.x86_64 >>> vdso_install KERNELRELEASE=3.16.0-0.rc0.git1.1.fc21.x86_64 >>> make[1]: *** No rule to make target `arch/x86/vdso/vdso.so.dbg', >>> needed by `vdso.so'. Stop. >>> make: *** [vdso_install] Error 2 >>> >>> The crazy Fedora versioning there corresponds to >>> 3f17ea6dea8ba5668873afa54628a91aaa3fb1c0 in Linus' tree. I'll poke at >>> this some, but if you have some quick ideas I'd be happy to try them. >> >> OK, I'm stumped. Looking at that commit, it removes all target >> invocations for vdso.so. Which means even a simple 'make' in the vdso >> directory fails with: >> >> [jwboyer@vader vdso]$ make >> make: *** No rule to make target `/vdso.so', needed by `/vdso.o'. Stop. >> [jwboyer@vader vdso]$ >> >> So how was this commit build tested? >> > > Since when do we support "make" in a subdirectory? Dunno. Since when do we break existing make targets that worked fine? Seriously, I'm just asking how this was build tested so I can try and duplicate that and then figure out how to fix the actual bug. josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/