Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933756AbaFKRaq (ORCPT ); Wed, 11 Jun 2014 13:30:46 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:40940 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933102AbaFKRaZ (ORCPT ); Wed, 11 Jun 2014 13:30:25 -0400 MIME-Version: 1.0 In-Reply-To: <5397F24A.7020407@zytor.com> References: <1402463064-31697-1-git-send-email-yinghai@kernel.org> <5397F24A.7020407@zytor.com> Date: Wed, 11 Jun 2014 10:30:25 -0700 X-Google-Sender-Auth: SClGtFjOMUIQUNgxqZ7l7uCc6GE Message-ID: Subject: Re: [PATCH] x86: Find correct 64 bit ramdisk address for microcode early update From: Yinghai Lu To: "H. Peter Anvin" Cc: Ingo Molnar , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 10, 2014 at 11:08 PM, H. Peter Anvin wrote: > On 06/10/2014 10:04 PM, Yinghai Lu wrote: >> When using kexec with 64bit kernel, bzImage and ramdisk could be >> loaded above 4G. We need this to get correct ramdisk adress. >> >> Make get_ramdisk_image() global and use it for early microcode >> updating. Also make it to take boot_params pointer for different >> usage. >> >> Signed-off-by: Yinghai Lu >> > > Have you tested this with early microcode loading on a 32-bit kernel? > No, I did not test that on a 32bit kernel. We did not enabled ramdisk loading high above 4G, right? Do you want to me to drop changes for 32 bit path (under those MARCO)? like: +++ linux-2.6/arch/x86/kernel/cpu/ microcode/amd_early.c @@ -51,12 +51,12 @@ static struct cpio_data __init find_ucod */ p = (struct boot_params *)__pa_nodebug(&boot_params); path = (char *)__pa_nodebug(ucode_path); - start = (void *)p->hdr.ramdisk_image; - size = p->hdr.ramdisk_size; + start = (void *)(unsigned long)get_ramdisk_image(p); + size = get_ramdisk_size(p); +++ linux-2.6/arch/x86/kernel/cpu/microcode/intel_early.c boot_params_p = (struct boot_params *)__pa_nodebug(&boot_params); - ramdisk_image = boot_params_p->hdr.ramdisk_ image; - ramdisk_size = boot_params_p->hdr.ramdisk_size; + ramdisk_image = get_ramdisk_image(boot_params_p); + ramdisk_size = get_ramdisk_size(boot_params_p); initrd_start_early = ramdisk_image; initrd_end_early = initrd_start_early + ramdisk_size; BTW, Is there any 32bit bootloader that could load ramdisk above 4G? Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/