Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbaFKSIL (ORCPT ); Wed, 11 Jun 2014 14:08:11 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:65053 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbaFKSIJ (ORCPT ); Wed, 11 Jun 2014 14:08:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <1986515.ZPZrccsmiq@vostro.rjw.lan> Date: Wed, 11 Jun 2014 20:08:08 +0200 X-Google-Sender-Auth: lFDehEnCujmEWO7Em2_xrgYJCPo Message-ID: Subject: Re: [PATCH] ACPI / hotplug / PCI: Add hotplug contexts to PCI host bridges From: "Rafael J. Wysocki" To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , ACPI Devel Maling List , Linux Kernel Mailing List , Mika Westerberg , Linux PCI Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 11, 2014 at 4:29 AM, Bjorn Helgaas wrote: > On Tue, Jun 10, 2014 at 2:51 PM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> After relatively recent changes in the ACPI-based PCI hotplug >> (ACPIPHP) code, the acpiphp_check_host_bridge() executed for PCI >> host bridges via acpi_pci_root_scan_dependent() doesn't do anything >> useful, because those bridges do not have hotplug contexts. That >> happens by mistake, so fix it by making acpiphp_enumerate_slots() >> add hotplug contexts to PCI host bridges too and modify >> acpiphp_remove_slots() to drop those contexts for host bridges >> as appropriate. >> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=76901 >> Fixes: 2d8b1d566a5f (ACPI / hotplug / PCI: Get rid of check_sub_bridges()) >> Reported-and-tested-by: Gavin Guo >> Cc: 3.15+ # 3.15+ >> Signed-off-by: Rafael J. Wysocki > > Acked-by: Bjorn Helgaas Thanks! > Rafael, do you want to merge this via your tree, since you merged the > original acpiphp rework? Yes, I'll take care of this. > I do have a small cleanup of acpiphp_glue.c in my queue, but it won't > conflict with this. > > Thanks a lot for fixing this! You're very welcome. :-) Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/