Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbaFKTBx (ORCPT ); Wed, 11 Jun 2014 15:01:53 -0400 Received: from mail-ve0-f172.google.com ([209.85.128.172]:56782 "EHLO mail-ve0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752572AbaFKTBw (ORCPT ); Wed, 11 Jun 2014 15:01:52 -0400 MIME-Version: 1.0 In-Reply-To: <20140611184422.GA13296@ravnborg.org> References: <5398749B.4090209@zytor.com> <20140611163628.GA12685@ravnborg.org> <20140611184422.GA13296@ravnborg.org> From: Andy Lutomirski Date: Wed, 11 Jun 2014 12:01:31 -0700 Message-ID: Subject: Re: [PATCH 0/2] x86,vdso,kbuild: Fix vdso_install To: Sam Ravnborg Cc: Josh Boyer , "H. Peter Anvin" , Michal Marek , "linux-kbuild@vger.kernel.org" , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 11, 2014 at 11:44 AM, Sam Ravnborg wrote: > On Wed, Jun 11, 2014 at 12:41:56PM -0400, Josh Boyer wrote: >> On Wed, Jun 11, 2014 at 12:36 PM, Sam Ravnborg wrote: >> > On Wed, Jun 11, 2014 at 09:20:05AM -0700, Andy Lutomirski wrote: >> >> This changes kbuild slightly because I didn't want to fight with using >> >> static pattern rules and extra obfuscated fake targets just to write a >> >> loop. >> > >> > What are you trying to fix with this? >> > >> > On my box (32 bit Intel) "make MODLIB=~/mod vdso_install" >> > works as expected. >> > Two *.so files are installed as a copy of the so.dbg files. >> >> With what tree? > Linus latest - yes. > >> With Linus' latest, I reported an error because >> commit 6f121e548f83674ab4920a4e60afb58d4f61b829 breaks the >> vdso_install target. > This is your bug-report: http://marc.info/?l=linux-kernel&m=140249607823283&w=2 > > + make -s ARCH=x86_64 > INSTALL_MOD_PATH=/home/jwboyer/rpmbuild/BUILDROOT/kernel-3.16.0-0.rc0.git1.1.fc21.x86_64 > vdso_install KERNELRELEASE=3.16.0-0.rc0.git1.1.fc21.x86_64 > make[1]: *** No rule to make target `arch/x86/vdso/vdso.so.dbg', > needed by `vdso.so'. Stop. > make: *** [vdso_install] Error 2 > > I am building for i386 which is why I do not see the bug. I didn't actually check whether all of the code I removed in the patch was wrong or just some. If you have a better suggestion for how to structure the makefile rule, I'd be interested. I don't speak makefilese very well. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/