Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbaFKTQP (ORCPT ); Wed, 11 Jun 2014 15:16:15 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:37718 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbaFKTQO (ORCPT ); Wed, 11 Jun 2014 15:16:14 -0400 Date: Wed, 11 Jun 2014 21:16:09 +0200 From: Sam Ravnborg To: Andy Lutomirski Cc: Josh Boyer , "H. Peter Anvin" , Michal Marek , "linux-kbuild@vger.kernel.org" , "Linux-Kernel@Vger. Kernel. Org" Subject: Re: [PATCH 2/2] x86,vdso: Fix vdso_install Message-ID: <20140611191609.GA16069@ravnborg.org> References: <5398749B.4090209@zytor.com> <20140611185119.GA13412@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > Can we please fix this in a way where we do not need to add stuff to core kbuild. > > If the original approach was used then make took care of the looping > > and the foreach part was not needed. Following is my first quick approach. It reuses the old - a little complex logic to do the looping and copying. Thsi is only tested on my i386 box / build. Sam diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile index 9769df0..39fb152 100644 --- a/arch/x86/vdso/Makefile +++ b/arch/x86/vdso/Makefile @@ -9,11 +9,6 @@ VDSOX32-$(CONFIG_X86_X32_ABI) := y VDSO32-$(CONFIG_X86_32) := y VDSO32-$(CONFIG_COMPAT) := y -vdso-install-$(VDSO64-y) += vdso.so -vdso-install-$(VDSOX32-y) += vdsox32.so -vdso-install-$(VDSO32-y) += $(vdso32-images) - - # files to link into the vdso vobjs-y := vdso-note.o vclock_gettime.o vgetcpu.o @@ -179,12 +174,12 @@ GCOV_PROFILE := n # Install the unstripped copy of vdso*.so listed in $(vdso-install-y). # quiet_cmd_vdso_install = INSTALL $@ - cmd_vdso_install = cp $(obj)/$@.dbg $(MODLIB)/vdso/$@ -$(vdso-install-y): %.so: $(obj)/%.so.dbg FORCE + cmd_vdso_install = cp $(obj)/$@ $(MODLIB)/vdso/$(@:.dbg=) +$(vdso_img_sodbg): %.so.dbg: $(obj)/%.so.dbg FORCE @mkdir -p $(MODLIB)/vdso $(call cmd,vdso_install) -PHONY += vdso_install $(vdso-install-y) -vdso_install: $(vdso-install-y) +PHONY += vdso_install $(vdso_img_sodbg) +vdso_install: $(vdso_img_sodbg) clean-files := vdso32-syscall* vdso32-sysenter* vdso32-int80* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/