Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932587AbaFLHnq (ORCPT ); Thu, 12 Jun 2014 03:43:46 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43507 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932399AbaFLHnp (ORCPT ); Thu, 12 Jun 2014 03:43:45 -0400 Date: Thu, 12 Jun 2014 10:43:21 +0300 From: Dan Carpenter To: navin patidar Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH 06/22] staging: rtl8188eu: Instead of intf_hdl pass adapter in read & write functions Message-ID: <20140612074321.GT5500@mwanda> References: <1402507301-3722-1-git-send-email-navin.patidar@gmail.com> <1402507301-3722-6-git-send-email-navin.patidar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1402507301-3722-6-git-send-email-navin.patidar@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 11, 2014 at 10:51:25PM +0530, navin patidar wrote: > diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c > index a0a31e6..85306bf 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_io.c > +++ b/drivers/staging/rtl8188eu/core/rtw_io.c > @@ -57,10 +57,10 @@ u8 _rtw_read8(struct adapter *adapter, u32 addr) > u8 r_val; > struct io_priv *pio_priv = &adapter->iopriv; > struct intf_hdl *pintfhdl = &(pio_priv->intf); > - u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr); > + u8 (*_read8)(struct adapter *pintfhdl, u32 addr); ^^^^^^^^ Could you send a follow on patch to change pintfhdl to adapter in all the declarations? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/