Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932803AbaFLIjQ (ORCPT ); Thu, 12 Jun 2014 04:39:16 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:34115 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754405AbaFLIjO (ORCPT ); Thu, 12 Jun 2014 04:39:14 -0400 Message-ID: <1402562338.8095.4.camel@jlt4.sipsolutions.net> Subject: Re: [patch V2] wireless: mwifiex: Use the proper interfaces From: Johannes Berg To: Thomas Gleixner Cc: Bing Zhao , LKML , John Stultz , Peter Zijlstra , Ingo Molnar , "John W. Linville" , "linux-wireless@vger.kernel.org" Date: Thu, 12 Jun 2014 10:38:58 +0200 In-Reply-To: (sfid-20140612_103227_131521_9EAF500A) References: <20140611234024.103571777@linutronix.de> <20140611234607.607201623@linutronix.de> <477F20668A386D41ADCC57781B1F70430FE1F8B507@SC-VEXCH1.marvell.com> (sfid-20140612_103227_131521_9EAF500A) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-06-12 at 10:31 +0200, Thomas Gleixner wrote: > + u32 queue_delay = ktime_to_ms(net_timedelta(skb->tstamp)); FWIW, I think the same as patch 12 applies here. net_timedelta() doesn't really seem to be a good way to calculate time deltas. And yes - I've seen situations where this matters, e.g. when running ntpdate after system startup. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/