Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933510AbaFLNX3 (ORCPT ); Thu, 12 Jun 2014 09:23:29 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:42773 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932669AbaFLNX0 (ORCPT ); Thu, 12 Jun 2014 09:23:26 -0400 Message-ID: <5399A944.40000@ti.com> Date: Thu, 12 Jun 2014 18:51:08 +0530 From: Sricharan R User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jason Cooper CC: , , , , , , , , , Subject: Re: [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list References: <1402574007-13987-1-git-send-email-r.sricharan@ti.com> <1402574007-13987-11-git-send-email-r.sricharan@ti.com> <20140612131600.GW8664@titan.lakedaemon.net> In-Reply-To: <20140612131600.GW8664@titan.lakedaemon.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jason, On Thursday 12 June 2014 06:46 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:18PM +0530, Sricharan R wrote: >> From: Rajendra Nayak >> >> On DRA7 compatible IRQ crossbar, IRQ 10 default mapped to L3_APP_IRQ, >> IRQ133 is default mapped to NMI pin, 139 and 140 crossbars are >> unused(not routed). Mark these as unused crossbar IRQs. >> >> Technical Reference Manual documentation update expected >> DRA72x-TRMINC00067 is being used to track the update. >> >> Reported-by: Nishanth Menon >> Reported-by: Sricharan R >> Reported-by: Suman Anna >> Signed-off-by: Rajendra Nayak >> --- >> drivers/irqchip/irq-crossbar.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c >> index 7d4db07..42a2e62 100644 >> --- a/drivers/irqchip/irq-crossbar.c >> +++ b/drivers/irqchip/irq-crossbar.c >> @@ -253,8 +253,8 @@ err1: >> return -ENOMEM; >> } >> >> -/* irq number 10 cannot be used because of hw bug */ >> -static int dra_irqs_unused[] = { 10 }; >> +/* irq number 10,133,139 and 140 cannot be used because of hw bug */ >> +static int dra_irqs_unused[] = { 10 , 133, 139, 140 }; > > see my earlier comment regarding a potential dts property. > Ok, if dts would be the better approach then I can change this. Regards, Sricharan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/