Message-ID: <1402595714.12385.13.camel@joe-AO725>
Subject: Re: [PATCH v2 1/2]
 drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style
From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Wahib Faizi <wahibfaizi@gmail.com>,
        Valentina Manea <valentina.manea.m@gmail.com>,
        linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Thu, 12 Jun 2014 10:55:14 -0700
In-Reply-To: <20140612175400.GA30060@kroah.com>
References: <1402569338-5709-1-git-send-email-wahibfaizi@gmail.com>
	 <1402594340-10867-1-git-send-email-wahibfaizi@gmail.com>
	 <1402594340-10867-2-git-send-email-wahibfaizi@gmail.com>
	 <20140612175400.GA30060@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Thu, 2014-06-12 at 10:54 -0700, Greg Kroah-Hartman wrote:
> On Thu, Jun 12, 2014 at 09:32:19PM +0400, Wahib Faizi wrote:
> > Fix coding style issue "do not use assignment in if condition"
> > detected by checkpatch.pl in usbip_host_driver.c.
> > 
> > Signed-off-by: Wahib Faizi <wahibfaizi@gmail.com>
> 
> Both of these patches have the same Subject: line, which isn't good as
> it doesn't make much sense.
> 
> You can also shorten it a lot, for example, this one should be:
>   Subject: staging: usbip: usbip_host_driver.c: fix if assignment style issue

True.  usbip_host_driver.c doesn't add much though.

It could even be something like:

staging: usbip: avoid assignment in if


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/