Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbaFLVFn (ORCPT ); Thu, 12 Jun 2014 17:05:43 -0400 Received: from mail-we0-f181.google.com ([74.125.82.181]:34078 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752916AbaFLVFm (ORCPT ); Thu, 12 Jun 2014 17:05:42 -0400 From: Dmitry Kasatkin X-Google-Original-From: Dmitry Kasatkin To: ming.lei@canonical.com Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Dmitry Kasatkin Subject: [PATCH 1/1] firmware: read firmware size using i_size_read() Date: Fri, 13 Jun 2014 00:05:09 +0300 Message-Id: <2fedf03f1007357f68f655d0a629dd1c390c242e.1402607108.git.d.kasatkin@samsung.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to read attr because inode structure contains size of the file. Use i_size_read() instead. Signed-off-by: Dmitry Kasatkin --- drivers/base/firmware_class.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index c30df50e..9aaa97b 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -279,26 +279,13 @@ static const char * const fw_path[] = { module_param_string(path, fw_path_para, sizeof(fw_path_para), 0644); MODULE_PARM_DESC(path, "customized firmware image search path with a higher priority than default path"); -/* Don't inline this: 'struct kstat' is biggish */ -static noinline_for_stack int fw_file_size(struct file *file) -{ - struct kstat st; - if (vfs_getattr(&file->f_path, &st)) - return -1; - if (!S_ISREG(st.mode)) - return -1; - if (st.size != (int)st.size) - return -1; - return st.size; -} - static int fw_read_file_contents(struct file *file, struct firmware_buf *fw_buf) { int size; char *buf; int rc; - size = fw_file_size(file); + size = i_size_read(file_inode(file)); if (size <= 0) return -EINVAL; buf = vmalloc(size); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/