Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbaFMHuQ (ORCPT ); Fri, 13 Jun 2014 03:50:16 -0400 Received: from mail.skyhub.de ([78.46.96.112]:40155 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbaFMHuO (ORCPT ); Fri, 13 Jun 2014 03:50:14 -0400 Date: Fri, 13 Jun 2014 09:50:11 +0200 From: Borislav Petkov To: Vivek Goyal Cc: WANG Chao , Dave Young , mjg59@srcf.ucam.org, bhe@redhat.com, jkosina@suse.cz, greg@kroah.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, ebiederm@xmission.com, hpa@zytor.com, akpm@linux-foundation.org Subject: Re: [PATCH 07/13] kexec: Implementation of new syscall kexec_file_load Message-ID: <20140613075011.GA4751@pd.tnic> References: <1401800822-27425-1-git-send-email-vgoyal@redhat.com> <1401800822-27425-8-git-send-email-vgoyal@redhat.com> <20140606065605.GE2785@dhcp-17-89.nay.redhat.com> <20140606181859.GK1526@redhat.com> <20140609021122.GB1924@darkstar.nay.redhat.com> <20140609053538.GA2874@dhcp-17-89.nay.redhat.com> <20140609154137.GD22049@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140609154137.GD22049@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 09, 2014 at 11:41:37AM -0400, Vivek Goyal wrote: > IIUC, COMMAND_LINE_SIZE gives max limits of running kernel and it does > not tell us anything about command line size supported by kernel being > loaded. Whatever you do, you do need a sane default because even querying the boot protocol is not reliable as the to-be-loaded kernel's boot protocol might be manipulated too, before signing (who knows what people do in the wild). So having a sane, unconditional fallback COMMAND_LINE_SIZE from the first kernel is a must, methinks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/