Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468AbaFMLyW (ORCPT ); Fri, 13 Jun 2014 07:54:22 -0400 Received: from mail-oa0-f51.google.com ([209.85.219.51]:44191 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbaFMLyU (ORCPT ); Fri, 13 Jun 2014 07:54:20 -0400 MIME-Version: 1.0 In-Reply-To: <5398758F.4080306@samsung.com> References: <1402090985-8061-1-git-send-email-dianders@chromium.org> <20140607181221.GB25068@e102568-lin.cambridge.arm.com> <20140609223831.GB16889@e102568-lin.cambridge.arm.com> <5398758F.4080306@samsung.com> Date: Fri, 13 Jun 2014 17:24:20 +0530 X-Google-Sender-Auth: H9sAbocRfdeuCVCkNa8HAP0LIsQ Message-ID: Subject: Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start From: Chander Kashyap To: Kukjin Kim Cc: Doug Anderson , Chander Kashyap , Nicolas Pitre , "linux-arm-kernel@lists.infradead.org" , "linux@arm.linux.org.uk" , Kevin Hilman , Andrew Bresticker , Inderpal Singh , "linux-kernel@vger.kernel.org" , Chander Kashyap , "olof@lixom.net" , Tushar Behera , Lorenzo Pieralisi , Thomas Abraham , Abhilash Kesavan , Javier Martinez Canillas , "linux-samsung-soc@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 11, 2014 at 8:58 PM, Kukjin Kim wrote: > On 06/12/14 00:19, Doug Anderson wrote: >> >> Chander, >> >> On Tue, Jun 10, 2014 at 9:52 PM, Chander Kashyap >> wrote: >>> >>> Hi Doug, >>> >>> On Tue, Jun 10, 2014 at 9:19 PM, Nicolas Pitre >>> wrote: >>>> >>>> On Tue, 10 Jun 2014, Doug Anderson wrote: >>>> >>>>> My S-state knowledge is not strong, but I believe that Lorenzo's >>>>> questions matter if we're using S2 for CPUidle (where we actually turn >>>>> off power and hot unplug CPUs) but not when we're using S1 for CPUidle >>>>> (where we just enter WFI/WFE). >>>>> >>> >>> No Its not plain WFI. >>> >>> All cores in Exynos5420 can be powered off independently. >>> This functionality has been tested. >>> >>> Below is the link for the posted patches. >>> >>> https://lkml.org/lkml/2014/6/10/194 >>> >>> And as Nicolas wrote, these patches need MCPM for that. >> >> >> Most excellent! I should have been more clear that I only knew about >> how CPUidle worked in our local production kernel. There I'm pretty >> sure CPUidle is just WFI/WFE. If you've got patches to do better then >> that's great! >> >> ...can you confirm that my patch doesn't interfere with your improved >> CPUidle? It's been Acked by Nicolas (thanks!) so I'd imagine it will >> land shortly. Kukjin: I assume you'll be taking this? >> This patch is effectively changing the mcpm_entry_point address from nsbase + 0x1c to nsbase + 0x8 Hence while integrating with mainline u-boot we need to take care for new mcpm_entry_point address. With Chromebook it works straightforward. > Sure, I will ;-) > > Thanks, > Kukjin > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/