Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753328AbaFMQDO (ORCPT ); Fri, 13 Jun 2014 12:03:14 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54821 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751520AbaFMQDN (ORCPT ); Fri, 13 Jun 2014 12:03:13 -0400 MIME-Version: 1.0 In-Reply-To: <248c69602c96d68aea1ffb4cb75e77ec38b6b75f.1402672110.git.d.kasatkin@samsung.com> References: <248c69602c96d68aea1ffb4cb75e77ec38b6b75f.1402672110.git.d.kasatkin@samsung.com> Date: Sat, 14 Jun 2014 00:03:10 +0800 Message-ID: Subject: Re: [PATCH v2 1/1] firmware: read firmware size using i_size_read() From: Ming Lei To: Dmitry Kasatkin Cc: Greg Kroah-Hartman , Linux Kernel Mailing List , Dmitry Kasatkin Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 13, 2014 at 11:09 PM, Dmitry Kasatkin wrote: > There is no need to read attr because inode structure contains size > of the file. Use i_size_read() instead. > > Signed-off-by: Dmitry Kasatkin Acked-by: Ming Lei Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/