Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753930AbaFMR23 (ORCPT ); Fri, 13 Jun 2014 13:28:29 -0400 Received: from mail-ve0-f182.google.com ([209.85.128.182]:35499 "EHLO mail-ve0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753854AbaFMR21 (ORCPT ); Fri, 13 Jun 2014 13:28:27 -0400 MIME-Version: 1.0 In-Reply-To: <539B33E1.7040500@zytor.com> References: <539B33E1.7040500@zytor.com> From: Andy Lutomirski Date: Fri, 13 Jun 2014 10:28:06 -0700 Message-ID: Subject: Re: [PATCH v3] x86,vdso: Fix vdso_install To: "H. Peter Anvin" Cc: Josh Boyer , Michal Marek , "linux-kbuild@vger.kernel.org" , "Linux-Kernel@Vger. Kernel. Org" , Sam Ravnborg Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 13, 2014 at 10:24 AM, H. Peter Anvin wrote: > On 06/12/2014 10:01 AM, Josh Boyer wrote: >> On Thu, Jun 12, 2014 at 11:28 AM, Andy Lutomirski wrote: >>> The filenames are different now. Inspired by a patch from >>> Sam Ravnborg. >>> >>> Acked-by: Sam Ravnborg >>> Reported-by: Josh Boyer >>> Signed-off-by: Andy Lutomirski >> >> Things look great with this version. Thanks much! >> >> Tested-by: Josh Boyer >> > > Are we okay with the 64-bit vdso now being installed as vdso64.so? Unless someone actually complains, I think so. Ideally, I think we'd have a symlink from the build id, but that's a separate issue. AFAIK, the only thing that actually references these files is Fedora's gdb, which is finding them from Fedora's build-id symlinks, which should work fine regardless of what the thing is called. How's this for a patch description: make vdso_install has been broken since this commit: commit 6f121e548f83674ab4920a4e60afb58d4f61b829 Author: Andy Lutomirski Date: Mon May 5 12:19:34 2014 -0700 x86, vdso: Reimplement vdso.so preparation in build-time C because the names of the files to be installed changed. This fixes vdso_install to install the right files. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/