Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753990AbaFMRah (ORCPT ); Fri, 13 Jun 2014 13:30:37 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:50433 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753840AbaFMRad (ORCPT ); Fri, 13 Jun 2014 13:30:33 -0400 MIME-Version: 1.0 In-Reply-To: References: <20140610165700.GA3453@www.outflux.net> Date: Fri, 13 Jun 2014 10:30:33 -0700 X-Google-Sender-Auth: tq2Gs8ezHzDKO7AlQplwKyeRsIg Message-ID: Subject: Re: [PATCH] of: avoid format string parsing in kobject names From: Kees Cook To: Rob Herring Cc: "linux-kernel@vger.kernel.org" , Grant Likely , Rob Herring , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 13, 2014 at 7:55 AM, Rob Herring wrote: > On Tue, Jun 10, 2014 at 11:57 AM, Kees Cook wrote: >> This makes sure a format string cannot leak into the kobject name that >> is constructed. (And splits the >80 character line.) >> >> Signed-off-by: Kees Cook > > Applied. > > This seems like a non-obvious thing to do, but I guess most people > aren't dealing directly with kobjects. Yeah, it's really unlikely this could get reached, but I just keep cleaning this up any time I see them just to be safe. :) Thanks! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/