Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753786AbaFMVNS (ORCPT ); Fri, 13 Jun 2014 17:13:18 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:57827 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbaFMVNQ (ORCPT ); Fri, 13 Jun 2014 17:13:16 -0400 MIME-Version: 1.0 In-Reply-To: <539B2B7F.8010900@gmail.com> References: <539A91E2.7000606@gmail.com> <539B2B7F.8010900@gmail.com> From: Rob Herring Date: Fri, 13 Jun 2014 16:12:55 -0500 Message-ID: Subject: Re: [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root To: Frank Rowand Cc: Pantelis Antoniou , Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , Linux Kernel list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 13, 2014 at 11:49 AM, Frank Rowand wrote: > On 6/13/2014 6:52 AM, Rob Herring wrote: >> On Fri, Jun 13, 2014 at 12:53 AM, Frank Rowand wrote: >>> From: Frank Rowand >>> >>> Pantelis Antoniou reports that of_find_node_by_path() is borked because >>> of_allnodes is not guaranteed to contain the root of the tree after using >>> any of the dynamic update functions because some other nodes ends up as >>> of_allnodes. >>> >>> Fixes: c22e650e66b8 of: Make of_find_node_by_path() handle /aliases >> >> Is it not possible to do a fix in of_find_node_by_path instead? I just > > Yes, the code for that is in https://lkml.org/lkml/2014/5/20/758 > > Or as Grant said in his reply, just use the fix in of_attach_node() for > now since he is going to replace the custom list. Okay, I've applied. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/