Message-ID: <1402765314.2756.20.camel@joe-AO725>
Subject: Re: [PATCH] Coccinelle : Script to detect cast after memory
 allocation
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Himangi Saraogi <himangi774@gmail.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.cz>,
        cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Date: Sat, 14 Jun 2014 10:01:54 -0700
In-Reply-To: <alpine.DEB.2.02.1406141809050.1962@localhost6.localdomain6>
References: <20140614154541.GA4179@himangi-Dell>
	 <1402761961.2756.12.camel@joe-AO725>
	 <alpine.DEB.2.02.1406141809050.1962@localhost6.localdomain6>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 895
Lines: 38

On Sat, 2014-06-14 at 18:11 +0200, Julia Lawall wrote:
> On Sat, 14 Jun 2014, Joe Perches wrote:
[]
> > Perhaps make this more generic for any void *?
> > 
> > Something like:
> > 
> > @@
> > void *t;
> > type other;
> > @@
> > 
> > -       (other *)t
> > +       t
[]
> Perhaps it would be reasonable to add this among the specific functions.  
> That is, t could be part of the disjunctions.

You do have to make sure that the
"casted to" type is not dereferenced.

ie: don't transform

void func(void *foo)
{
	unsigned long bar = *(unsigned long *)foo;
}

Also there may be some __user cast types and
such that may be necessary to exclude too.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/