Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbaFOWCZ (ORCPT ); Sun, 15 Jun 2014 18:02:25 -0400 Received: from netrider.rowland.org ([192.131.102.5]:48272 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752307AbaFOWCY (ORCPT ); Sun, 15 Jun 2014 18:02:24 -0400 Date: Sun, 15 Jun 2014 18:02:23 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Joe Perches cc: linux-kernel@vger.kernel.org, Paul Zimmerman , Greg Kroah-Hartman , Subject: Re: [PATCH -next 24/26] usb: Use dma_zalloc_coherent In-Reply-To: <1816dd87707535b6442e5c75fde9f799821c457a.1402863905.git.joe@perches.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 15 Jun 2014, Joe Perches wrote: > Use the zeroing function instead of dma_alloc_coherent & memset(,0,) > > Signed-off-by: Joe Perches ... > diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c > index 27f35e8..681fc5e 100644 > --- a/drivers/usb/host/uhci-hcd.c > +++ b/drivers/usb/host/uhci-hcd.c > @@ -589,15 +589,14 @@ static int uhci_start(struct usb_hcd *hcd) > uhci->dentry = dentry; > #endif > > - uhci->frame = dma_alloc_coherent(uhci_dev(uhci), > - UHCI_NUMFRAMES * sizeof(*uhci->frame), > - &uhci->frame_dma_handle, 0); > + uhci->frame = dma_zalloc_coherent(uhci_dev(uhci), > + UHCI_NUMFRAMES * sizeof(*uhci->frame), > + &uhci->frame_dma_handle, 0); Please don't change the coding style. This file indents continuation lines by two tab stops; it doesn't align things with opening parens. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/