Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336AbaFOWQe (ORCPT ); Sun, 15 Jun 2014 18:16:34 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:62941 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbaFOWQd (ORCPT ); Sun, 15 Jun 2014 18:16:33 -0400 MIME-Version: 1.0 In-Reply-To: <881b8f8d85c96b6e9d8735aa10bbf18468688b9d.1402863905.git.joe@perches.com> References: <881b8f8d85c96b6e9d8735aa10bbf18468688b9d.1402863905.git.joe@perches.com> Date: Mon, 16 Jun 2014 00:16:30 +0200 X-Google-Sender-Auth: wyWanRpDiQy23AOP3wC3a2SNc68 Message-ID: Subject: Re: [PATCH -next 25/26] fbdev: Use dma_zalloc_coherent From: Geert Uytterhoeven To: Joe Perches Cc: "linux-kernel@vger.kernel.org" , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Linux Fbdev development list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 15, 2014 at 10:37 PM, Joe Perches wrote: > diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c > index a8484f7..788f6b3 100644 > --- a/drivers/video/fbdev/da8xx-fb.c > +++ b/drivers/video/fbdev/da8xx-fb.c > @@ -1447,18 +1447,15 @@ static int fb_probe(struct platform_device *device) > da8xx_fb_fix.line_length - 1; > > /* allocate palette buffer */ > - par->v_palette_base = dma_alloc_coherent(NULL, > - PALETTE_SIZE, > - (resource_size_t *) > - &par->p_palette_base, > - GFP_KERNEL | GFP_DMA); > + par->v_palette_base = dma_zalloc_coherent(NULL, PALETTE_SIZE, > + (resource_size_t *)&par->p_palette_base, Suggestion for further cleanup: It seems this cast is no longer needed. > + GFP_KERNEL | GFP_DMA); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/