Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754283AbaFPHkk (ORCPT ); Mon, 16 Jun 2014 03:40:40 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:38020 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754102AbaFPHki (ORCPT ); Mon, 16 Jun 2014 03:40:38 -0400 X-Google-Original-Sender: Date: Mon, 16 Jun 2014 09:39:57 +0200 From: Johan Hovold To: Janne Kanniainen Cc: Johan Hovold , Jiri Kosina , Bryan Wu , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels Message-ID: <20140616073957.GA20636@localhost> References: <20140612090636.GK10256@localhost> <1402605252-9620-1-git-send-email-janne.kanniainen@gmail.com> <20140613075411.GG10940@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 15, 2014 at 05:59:40PM +0300, Janne Kanniainen wrote: > >> Ok, so you decided to continue setting mode on every LED brightness > >> update. That should be fine, but you never answered my question about > >> whether it is necessary? > > > > I decided to do it that way because official driver did it as well. I > > can check if it is necessary. > > Ok, I checked this one and every time you update LEDs brightness you > will need to update mode also. Ok, great. Then we know. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/