Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368AbaFPIGI (ORCPT ); Mon, 16 Jun 2014 04:06:08 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:57870 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754109AbaFPIGG (ORCPT ); Mon, 16 Jun 2014 04:06:06 -0400 Date: Mon, 16 Jun 2014 09:06:01 +0100 From: Lee Jones To: Dave Jones , Linux Kernel Mailing List , mporter@linaro.org Subject: Re: regulator: bcm590xx: Add support for regulators on secondary I2C slave Message-ID: <20140616080601.GE14323@lee--X1> References: <20140603192910.BB56066103D@gitolite.kernel.org> <20140610152255.GA20737@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140610152255.GA20737@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jun 2014, Dave Jones wrote: > On Tue, Jun 03, 2014 at 07:29:10PM +0000, Linux Kernel wrote: > > Gitweb: http://git.kernel.org/linus/;a=commit;h=c6466950e917890be3050171f6745ccb9d91d35f > > Commit: c6466950e917890be3050171f6745ccb9d91d35f > > Parent: 9e1e726311830bc5b8b568d5178f6a52c357fb6e > > Refname: refs/heads/next > > Author: Matt Porter > > AuthorDate: Wed Apr 23 19:21:32 2014 -0400 > > Committer: Lee Jones > > CommitDate: Wed May 21 10:40:16 2014 +0100 > > > > regulator: bcm590xx: Add support for regulators on secondary I2C slave > > > > The bcm590xx MFD driver now exposes a secondary regmap descriptor > > making the registers for regulators on the secondary I2C slave address > > available. Add support for GPLDO1-6 and VBUS regulators found within > > this register range. > > > -#define BCM590XX_NUM_REGS 20 > > +#define BCM590XX_NUM_REGS 27 > > Coverity picked up that this change has introduced a out of bounds read. > The loop in bcm590xx_probe iterates from 0 to NUM_REGS, > but the bcm590xx_regs struct it iterates over using the ptr 'info' is only 26 > elements. Nice little tool. :) Matt, I assume you'll fix this yourself? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/