Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754608AbaFPIP4 (ORCPT ); Mon, 16 Jun 2014 04:15:56 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:58894 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754242AbaFPIPw (ORCPT ); Mon, 16 Jun 2014 04:15:52 -0400 Date: Mon, 16 Jun 2014 09:15:39 +0100 From: Russell King - ARM Linux To: Nick Krause Cc: Maxime Ripard , Emilio =?iso-8859-1?Q?L=F3pez?= , Mike Turquette , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Frees gate after if statement in clk-sunxi.c Message-ID: <20140616081538.GV23430@n2100.arm.linux.org.uk> References: <1402769508-3821-1-git-send-email-xerofoify@gmail.com> <20140615203058.GA22265@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 15, 2014 at 11:31:41PM -0400, Nick Krause wrote: > Seems the bug is fixed , don't worry about resent patch. > Thanks Nick > > On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause wrote: > > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct > > device_node *node) > > u32 rate; > > > > if (of_property_read_u32(node, "clock-frequency", &rate)) > > + kfree(gate); > > return; In any case, the kernel is not coded in Python. C uses braces { } to enclose blocks of code, and does not care about indentation - indentation is meaningless to C. Python purely identifies blocks of code by indentation alone. Please take account of the programming language when creating patches. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/