Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754653AbaFPI05 (ORCPT ); Mon, 16 Jun 2014 04:26:57 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33751 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754103AbaFPI04 (ORCPT ); Mon, 16 Jun 2014 04:26:56 -0400 Date: Mon, 16 Jun 2014 11:26:52 +0300 From: Dan Carpenter To: Vitaly Osipov Cc: Greg Kroah-Hartman , Peng Tao , Joe Perches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: remove memset(0) after LIBCFS_ALLOC Message-ID: <20140616082651.GE5500@mwanda> References: <20140614072951.GA87525@witts-MacBook-Pro.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140614072951.GA87525@witts-MacBook-Pro.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 14, 2014 at 05:29:51PM +1000, Vitaly Osipov wrote: > Joe Perches mentioned on driverdev-devel that memset after LIBCFS_ALLOC > is not necessary as it is already done during LIBCFS_ALLOC_POST. This > commit removes these unnecessary memsets. Based on the results of running > a cocci patch along the lines of: > > @@ > expression E1, E2; > @@ > > LIBCFS_ALLOC (E1,E2); > ... > - memset(E1,0,E2); > > Signed-off-by: Vitaly Osipov Reviewed-by: Dan Carpenter regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/