Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753865AbaFPLVX (ORCPT ); Mon, 16 Jun 2014 07:21:23 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:60177 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753678AbaFPLVT (ORCPT ); Mon, 16 Jun 2014 07:21:19 -0400 Message-ID: <539ED2C0.8030405@gmail.com> Date: Mon, 16 Jun 2014 16:49:28 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Doug Anderson , Tushar Behera CC: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , Mike Turquette , Tomasz Figa , Russell King , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , Kukjin Kim , Kevin Hilman , Mark Brown Subject: Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board References: <1402464739-19044-1-git-send-email-tushar.b@samsung.com> <1402464739-19044-4-git-send-email-tushar.b@samsung.com> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/13/2014 10:33 PM, Doug Anderson wrote: > Tushar, > > On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: >> Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. > > If you want to be a stickler about it, peach-pi actually has a > max98091. That requires code changes to the i2c driver, though. > ...and unfortunately listing two compatible strings for i2c devices is > broken. :( > Hi Doug, You are right. I checked the boot logs, the detected codec type is MAX98091. Since both these CODECs are supported through a single driver and the detection of chip is done during runtime, I would suggest we go ahead with "max98090" compatible string. I will update the commit message accordingly. Does that sound okay to you? > >> Signed-off-by: Tushar Behera >> --- >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 31 +++++++++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index f3af207..76f5966 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -78,9 +78,27 @@ >> pinctrl-0 = <&usb301_vbus_en>; >> enable-active-high; >> }; >> + >> + sound { >> + compatible = "google,snow-audio-max98090"; >> + >> + samsung,i2s-controller = <&i2s0>; >> + samsung,audio-codec = <&max98090>; >> + }; >> +}; >> + >> +&i2s0 { >> + status = "okay"; > > It would be awfully nice to keep diffs between exynos5420-peach-pit > and exynos5800-peach-pi clean. They're 99% the same. I know this has > already gotten messed up with DP/HDMI were added, but there's no need > to make it worse. > If you so desire, I will submit a patch to sort peach-pi device-tree nodes (w.r.t. peach-pit dts file). > Could you add these nodes in the same place within the dts they were > added in exynos5420-peach-pit? > Okay, I will add it after watchdog node. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/