Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbaFPO0e (ORCPT ); Mon, 16 Jun 2014 10:26:34 -0400 Received: from elvis.franken.de ([193.175.24.41]:33371 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582AbaFPO0d (ORCPT ); Mon, 16 Jun 2014 10:26:33 -0400 Date: Mon, 16 Jun 2014 16:24:00 +0200 From: Thomas Bogendoerfer To: Sam Ravnborg Cc: Peter Hurley , Aaro Koskinen , David Miller , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, Greg Kroah-Hartman , Seth Bollinger , LinusTorvaldstorvalds@linux-foundation.org Subject: Re: Linux 3.15: SPARC serial console regression Message-ID: <20140616142400.GA11632@alpha.franken.de> References: <20140609205917.GA913@drone.musicnaut.iki.fi> <1402357697-20976-1-git-send-email-peter@hurleysoftware.com> <20140610192438.GA6846@ravnborg.org> <53977688.5080802@hurleysoftware.com> <20140615185635.GA22577@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140615185635.GA22577@ravnborg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 15, 2014 at 08:56:35PM +0200, Sam Ravnborg wrote: > On Tue, Jun 10, 2014 at 05:20:08PM -0400, Peter Hurley wrote: > > On 06/10/2014 03:24 PM, Sam Ravnborg wrote: > > >>From: Peter Hurley > > >>Date: Mon, 9 Jun 2014 19:21:43 -0400 > > >>Subject: [PATCH] serial: sunsab: Test for no tx data on tx restart > > >> > > >>Commit 717f3bbab3c7628736ef738fdbf3d9a28578c26c, > > >>'serial_core: Fix conditional start_tx on ring buffer not empty' > > >>exposes an incorrect assumption in sunsab's start_tx method; the > > >>tx ring buffer can, in fact, be empty when restarting tx when > > >>performing flow control. > > We have a report that commit 717f3bbab3c7628736ef738fdbf3d9a28578c26c > ("serial_core: Fix conditional start_tx on ring buffer not empty") > broke at least one more driver: > > Aaro Koskinen reported: > The same problem is present also on PowerPC G5 Xserve (pmac_zilog driver) > > And based on code review a third driver is broken: > > Sam Ravnborg reported: > Can you please take a look at sunzilog.c. > It looks like the same test is missing in sunzilog_start_tx(): > > This is a regression so we should either revert the above commit > or review and fix the remaining drivers. ip22zilog.c is also broken (clone of sunzilog). Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/