Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932104AbaFPO5F (ORCPT ); Mon, 16 Jun 2014 10:57:05 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:19167 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbaFPO5B (ORCPT ); Mon, 16 Jun 2014 10:57:01 -0400 Message-ID: <539F05BA.7070004@imgtec.com> Date: Mon, 16 Jun 2014 15:56:58 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Vince Weaver , CC: Peter Zijlstra , Ingo Molnar Subject: Re: [PATCH 3/6] metag,perf: Use common PMU interrupt disabled code References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.101] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vince, On 15/06/14 07:03, Vince Weaver wrote: > > Transition to using the new generic PERF_PMU_CAP_NO_INTERRUPT method for > failing a sampling event when no PMU interrupt is available. > > Signed-off-by: Vince Weaver > @@ -866,6 +856,15 @@ static int __init init_hw_perf_events(void) > pr_info("enabled with %s PMU driver, %d counters available\n", > metag_pmu->name, metag_pmu->max_events); > > + /* > + * Early cores have "limited" counters - they have no overflow > + * interrupts - and so are unable to do sampling without extra work > + * and timer assistance. > + */ > + if (metag_pmu->max_period == 0) { > + metag_pmu->pmu.capabilities |= PERF_PMU_CAP_NO_INTERRUPT; > + } The braces could be dropped. Otherwise looks good to me, Acked-by: James Hogan Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/