Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755561AbaFPQh4 (ORCPT ); Mon, 16 Jun 2014 12:37:56 -0400 Received: from linode.aoot.com ([69.164.194.13]:57434 "EHLO linode.aoot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753256AbaFPQhy (ORCPT ); Mon, 16 Jun 2014 12:37:54 -0400 Message-ID: <539F1D5E.30505@opengridcomputing.com> Date: Mon, 16 Jun 2014 11:37:50 -0500 From: Steve Wise User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Levente Kurusa , Nick Krause CC: swise@chelsio.com, roland@kernel.org, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4]Checks for Null value in function *get_skub References: <1402932328-3732-1-git-send-email-xerofoify@gmail.com> <539F0DAF.1020802@opengridcomputing.com> <539F112F.7030303@linux.com> In-Reply-To: <539F112F.7030303@linux.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/2014 10:45 AM, Levente Kurusa wrote: > On 06/16/2014 05:37 PM, Nick Krause wrote: >> Signed-off-by: Nicholas Krause >> --- >> drivers/infiniband/hw/cxgb4/ >> cm.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/infiniband/hw/cxgb4/cm.c >> b/drivers/infiniband/hw/cxgb4/cm.c >> index f9477e2..2d56983 100644 >> --- a/drivers/infiniband/hw/cxgb4/cm.c >> +++ b/drivers/infiniband/hw/cxgb4/cm.c >> @@ -340,15 +340,13 @@ static int status2errno(int status) >> */ >> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t >> gfp) >> { >> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { >> skb_trim(skb, 0); >> skb_get(skb); >> skb_reset_transport_header(skb); >> } else { >> + if (skb) >> /* NULL is ignored */. >> + kfree_skb (skb); >> skb = alloc_skb(len, gfp); >> } >> t4_set_arp_err_handler(skb, NULL, NULL); > > This patch is severely whitespace damaged. Can you fix your MUA > or try to use git-send-email? > > The changelog as well is of low quality. Maybe something like this: > > infiniband: cxgb4: fix memory skb memory leak > > ... would be better. > > Also, this fails the build, due to the extra dot character after > the comment. :-( > Agreed. Start over with this patch, do what we asked, and make sure it passes checkpatch... > Thanks, > Levente Kurusa. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/