Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932384AbaFPR01 (ORCPT ); Mon, 16 Jun 2014 13:26:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17605 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932195AbaFPR00 (ORCPT ); Mon, 16 Jun 2014 13:26:26 -0400 Date: Mon, 16 Jun 2014 13:25:38 -0400 From: Vivek Goyal To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, hpa@zytor.com, mjg59@srcf.ucam.org, greg@kroah.com, jkosina@suse.cz, dyoung@redhat.com, chaowang@redhat.com, bhe@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH 09/13] purgatory: Core purgatory functionality Message-ID: <20140616172538.GB4515@redhat.com> References: <1401800822-27425-1-git-send-email-vgoyal@redhat.com> <1401800822-27425-10-git-send-email-vgoyal@redhat.com> <20140605200523.GB26110@pd.tnic> <20140606195104.GM1526@redhat.com> <20140613101713.GD4751@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140613101713.GD4751@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 13, 2014 at 12:17:13PM +0200, Borislav Petkov wrote: > On Fri, Jun 06, 2014 at 03:51:04PM -0400, Vivek Goyal wrote: > > On Thu, Jun 05, 2014 at 10:05:23PM +0200, Borislav Petkov wrote: > > > > [..] > > > > @@ -249,6 +254,7 @@ archclean: > > > > $(Q)rm -rf $(objtree)/arch/x86_64 > > > > $(Q)$(MAKE) $(clean)=$(boot) > > > > $(Q)$(MAKE) $(clean)=arch/x86/tools > > > > > > ifeq ($(CONFIG_KEXEC),y) > > > $(Q)$(MAKE) $(clean)=arch/x86/purgatory > > > endif > > > > Hmm.., is it strictly required? I am wondering what happens if I build > > a kernel with CONFIG_KEXEC=y, then set CONFIG_KEXEC=n and do "make clean". > > Try it - it works here. > > > I think I will still like any files in arch/x86/purgatory to be cleaned > > despite the fact that CONFIG_KEXEC=n. Isn't it? > > Yep, that works. Conversely, we don't want people who haven't enabled > KEXEC ever to have unrelated cleanup delay. > I tried following with CONFIG_KEXEC=n ifeq ($(CONFIG_KEXEC),y) $(Q)$(MAKE) $(clean)=arch/x86/purgatory endif And still "make V=1 clean" shows me that it is going in purgatory dir to clean things up. make -f scripts/Makefile.clean obj=arch/x86/purgatory Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/