Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755776AbaFPTMK (ORCPT ); Mon, 16 Jun 2014 15:12:10 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:54939 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754490AbaFPTMH (ORCPT ); Mon, 16 Jun 2014 15:12:07 -0400 MIME-Version: 1.0 In-Reply-To: References: <539EE86E.6030806@profihost.ag> <6B8712E6-8012-42C3-9D98-0EBD943F2894@profihost.ag> Date: Mon, 16 Jun 2014 12:12:06 -0700 Message-ID: Subject: Re: netconsole breaks netpoll on bridge From: Cong Wang To: Stefan Priebe - Profihost AG Cc: Stephen Hemminger , David Miller , "bridge@lists.linux-foundation.org" , Linux Netdev List , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 16, 2014 at 12:05 PM, Stefan Priebe - Profihost AG wrote: > >> Am 16.06.2014 um 20:51 schrieb Cong Wang : >> >> On Mon, Jun 16, 2014 at 11:41 AM, Stefan Priebe - Profihost AG >> wrote: >>> >>>> Am 16.06.2014 um 20:05 schrieb Cong Wang : >>>> >>>> On Mon, Jun 16, 2014 at 5:51 AM, Stefan Priebe - Profihost AG >>>> wrote: >>>>> Hi, >>>>> >>>>> i'm using a vanilla 3.10.43 kernel and netconsole on top of a bridge. >>>>> >>>>> netconsole is used with vmbr0 (bridge) which is on top of bond0. >>>>> >>>>> If i want to add another bridge to vmbr0 is fails as long as netconsole >>>>> is in use. >>>>> >>>>> # brctl addif vmbr0 fwpr2004p0 >>>>> can't add fwpr2004p0 to bridge vmbr0: Unknown error 524 >>>>> >>>>> Kernel output: >>>>> netpoll: (null): fwpr2004p0 doesn't support polling, aborting >>>>> >>>>> If i do rmmod netconsole - everything is working fine again. >>>> >>>> This is expected, you can't add an interface which doesn't support >>>> netpoll to a bridge which is running netpoll. >>> >>> Thanks, so i can't use netconsole at a bridge used for vms? >> >> You can, but you need to make sure all the devices under >> this bridge support netpoll. Not considering mac learning, >> bridge just broadcasts all the packets to its ports, if one of them >> doesn't support netpoll, how could it work? > > Ok i was trying to add a veth device so this is the problematic device. > We can just add netpoll support to veth device, it should not be hard. I will work on it once net-next is open. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/