Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755675AbaFPTTg (ORCPT ); Mon, 16 Jun 2014 15:19:36 -0400 Received: from mail-ph.de-nserver.de ([85.158.179.214]:60062 "EHLO mail-ph.de-nserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754490AbaFPTTf convert rfc822-to-8bit (ORCPT ); Mon, 16 Jun 2014 15:19:35 -0400 X-Fcrdns: Yes References: <539EE86E.6030806@profihost.ag> <6B8712E6-8012-42C3-9D98-0EBD943F2894@profihost.ag> Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Message-Id: <835D3F57-EB3A-4D30-B19C-7CC987D06C55@profihost.ag> Cc: Stephen Hemminger , David Miller , "bridge@lists.linux-foundation.org" , Linux Netdev List , LKML X-Mailer: iPhone Mail (11D201) From: Stefan Priebe - Profihost AG Subject: Re: netconsole breaks netpoll on bridge Date: Mon, 16 Jun 2014 21:19:34 +0200 To: Cong Wang X-User-Auth: Auth by s.priebe@profihost.ag through 84.190.88.187 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 16.06.2014 um 21:12 schrieb Cong Wang : > > On Mon, Jun 16, 2014 at 12:05 PM, Stefan Priebe - Profihost AG > wrote: >> >>> Am 16.06.2014 um 20:51 schrieb Cong Wang : >>> >>> On Mon, Jun 16, 2014 at 11:41 AM, Stefan Priebe - Profihost AG >>> wrote: >>>> >>>>> Am 16.06.2014 um 20:05 schrieb Cong Wang : >>>>> >>>>> On Mon, Jun 16, 2014 at 5:51 AM, Stefan Priebe - Profihost AG >>>>> wrote: >>>>>> Hi, >>>>>> >>>>>> i'm using a vanilla 3.10.43 kernel and netconsole on top of a bridge. >>>>>> >>>>>> netconsole is used with vmbr0 (bridge) which is on top of bond0. >>>>>> >>>>>> If i want to add another bridge to vmbr0 is fails as long as netconsole >>>>>> is in use. >>>>>> >>>>>> # brctl addif vmbr0 fwpr2004p0 >>>>>> can't add fwpr2004p0 to bridge vmbr0: Unknown error 524 >>>>>> >>>>>> Kernel output: >>>>>> netpoll: (null): fwpr2004p0 doesn't support polling, aborting >>>>>> >>>>>> If i do rmmod netconsole - everything is working fine again. >>>>> >>>>> This is expected, you can't add an interface which doesn't support >>>>> netpoll to a bridge which is running netpoll. >>>> >>>> Thanks, so i can't use netconsole at a bridge used for vms? >>> >>> You can, but you need to make sure all the devices under >>> this bridge support netpoll. Not considering mac learning, >>> bridge just broadcasts all the packets to its ports, if one of them >>> doesn't support netpoll, how could it work? >> >> Ok i was trying to add a veth device so this is the problematic device. > > We can just add netpoll support to veth device, it should not be hard. > I will work on it once net-next is open. That sounds great! Is there anything I can do or some code I can port to veth? Greets, Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/