Message-ID: <1402964898.11561.2.camel@joe-AO725>
Subject: Re: [PATCH] checkpatch: Warn on unnecessary void function return
 statements
From: Joe Perches <joe@perches.com>
To: Anish Bhatt <anish@chelsio.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Date: Mon, 16 Jun 2014 17:28:18 -0700
In-Reply-To: <1402961300-17985-1-git-send-email-anish@chelsio.com>
References: <1401728316.5770.9.camel@joe-AO725>
	 <1402961300-17985-1-git-send-email-anish@chelsio.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-06-16 at 16:28 -0700, Anish Bhatt wrote:
> This seems to ignore the ability to exit from void
> return functions via a `return;` in case of an error
> or similar. Any attempt to bail out generates warnings
> with checkpathch.pl Perhaps it should check for returns
> only at the end of the function ? If not, is there a
> suggested way to do this ? goto labels can't be directly
> used in place either

The only time checkpatch should bleat any message
is when there is a return; statement indented with
a single tab.
 
This form should be fine and not generate any
checkpatch warning.

void function(void)
{
	...

	if (err)
		return;

	...

}


If you want to use exit labels, I suggest you
use this form:

void function(void)
{

	...

	if (err)
		goto exit;

	...

exit:
	;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/