Message-ID: <1402965017.11561.3.camel@joe-AO725>
Subject: Re: [PATCH -next 24/26] usb: Use dma_zalloc_coherent
From: Joe Perches <joe@perches.com>
To: Paul Zimmerman <Paul.Zimmerman@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Date: Mon, 16 Jun 2014 17:30:17 -0700
In-Reply-To: <A2CA0424C0A6F04399FB9E1CD98E0304844B776A@US01WEMBX2.internal.synopsys.com>
References: <cover.1402863904.git.joe@perches.com>
	 <1816dd87707535b6442e5c75fde9f799821c457a.1402863905.git.joe@perches.com>
	 <A2CA0424C0A6F04399FB9E1CD98E0304844B776A@US01WEMBX2.internal.synopsys.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-06-16 at 22:00 +0000, Paul Zimmerman wrote:
> > From: Joe Perches [mailto:joe@perches.com]
> > Sent: Sunday, June 15, 2014 1:38 PM
> > 
> > Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >  drivers/usb/dwc2/hcd_ddma.c | 20 +++++++-------------
> >  drivers/usb/host/uhci-hcd.c |  7 +++----
> >  2 files changed, 10 insertions(+), 17 deletions(-)
> > 
> > diff --git a/drivers/usb/dwc2/hcd_ddma.c b/drivers/usb/dwc2/hcd_ddma.c
> > index 3376177..ab8d7fc 100644
> > --- a/drivers/usb/dwc2/hcd_ddma.c
> > +++ b/drivers/usb/dwc2/hcd_ddma.c
> > @@ -87,17 +87,12 @@ static u16 dwc2_frame_incr_val(struct dwc2_qh *qh)
> >  static int dwc2_desc_list_alloc(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh,
> >  				gfp_t flags)
> >  {
> > -	qh->desc_list = dma_alloc_coherent(hsotg->dev,
> > -				sizeof(struct dwc2_hcd_dma_desc) *
> > -				dwc2_max_desc_num(qh), &qh->desc_list_dma,
> > -				flags);
> > -
> > +	qh->desc_list = dma_zalloc_coherent(hsotg->dev,
> > +					    sizeof(struct dwc2_hcd_dma_desc) * dwc2_max_desc_num(qh),
> > +					    &qh->desc_list_dma, flags);
> 
> This will cause checkpatch to complain about a too-long line, surely?

Hi Paul.

It does and I don't care.

> If you fix that, you can add my acked-by for the dwc2 parts.

If you care that much, I can fix it for you, but I
think it's better as a long line.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/