Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755342AbaFQEEk (ORCPT ); Tue, 17 Jun 2014 00:04:40 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:58413 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750942AbaFQEEi (ORCPT ); Tue, 17 Jun 2014 00:04:38 -0400 X-IronPort-AV: E=Sophos;i="5.00,723,1396972800"; d="scan'208";a="32003488" Message-ID: <1402977569.5755.3.camel@localhost.localdomain> Subject: Re: [PATCH v4] lib: add size unit t/p/e to memparse From: Gui Hecheng To: David Rientjes CC: , , Date: Tue, 17 Jun 2014 11:59:29 +0800 In-Reply-To: References: <1402623746-1171-1-git-send-email-guihc.fnst@cn.fujitsu.com> <1402968140.9806.6.camel@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.111] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-06-16 at 18:29 -0700, David Rientjes wrote: > On Tue, 17 Jun 2014, Gui Hecheng wrote: > > > > > diff --git a/lib/cmdline.c b/lib/cmdline.c > > > > index d4932f7..76a712e 100644 > > > > --- a/lib/cmdline.c > > > > +++ b/lib/cmdline.c > > > > @@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options); > > > > * @retptr: (output) Optional pointer to next char after parse completes > > > > * > > > > * Parses a string into a number. The number stored at @ptr is > > > > - * potentially suffixed with %K (for kilobytes, or 1024 bytes), > > > > - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or > > > > - * 1073741824). If the number is suffixed with K, M, or G, then > > > > - * the return value is the number multiplied by one kilobyte, one > > > > - * megabyte, or one gigabyte, respectively. > > > > + * potentially suffixed with K, M, G, T, P, E. > > > > */ > > > > > > > > unsigned long long memparse(const char *ptr, char **retptr) > > > > @@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char **retptr) > > > > unsigned long long ret = simple_strtoull(ptr, &endptr, 0); > > > > > > > > switch (*endptr) { > > > > + case 'E': > > > > + case 'e': > > > > + ret <<= 10; > > > > + case 'P': > > > > + case 'p': > > > > + ret <<= 10; > > > > + case 'T': > > > > + case 't': > > > > + ret <<= 10; > > > > case 'G': > > > > case 'g': > > > > ret <<= 10; > > > > > > Seems fine since unsigned long long is always at least 64 bits, but > > > perhaps also change simple_strtoull() to use kstrtoull() at the same time > > > since the former is deprecated? > > > > Yes, that is a point. But the deprecated function is a separate problem > > and may not be included in this patch. > > Also, I find that simple_strtoull is used in many places in the kernel > > code, it is better to replace it globally? > > > > If you're going to have a go at replacing the simple_strto*() functions > throughout the kernel, it's probably better to do it per subsystem (as > defined by the separate sections of MAINTAINERS) and propose the patches > individually to those maintainers. Once it has been removed entirely, you > can submit a patch to remove the functions themselves. > > Be aware that there are many callers to the deprecated functions so it may > take a significant amount of time. Hmmmm...It may really take a long time. But I am not sure whether this is really a good idea to do this big replacement. Let's see whether anyone would like to share his opinions. -Gui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/