Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754473AbaFQKFR (ORCPT ); Tue, 17 Jun 2014 06:05:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23472 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971AbaFQKFO (ORCPT ); Tue, 17 Jun 2014 06:05:14 -0400 Message-ID: <53A012C8.7060109@redhat.com> Date: Tue, 17 Jun 2014 12:04:56 +0200 From: Florian Weimer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: David Herrmann CC: Andy Lutomirski , "linux-kernel@vger.kernel.org" , Michael Kerrisk , Ryan Lortie , Linus Torvalds , Andrew Morton , "linux-mm@kvack.org" , Linux FS Devel , Linux API , Greg Kroah-Hartman , John Stultz , Lennart Poettering , Daniel Mack , Kay Sievers , Hugh Dickins , Tony Battersby Subject: Re: [PATCH v3 0/7] File Sealing & memfd_create() References: <1402655819-14325-1-git-send-email-dh.herrmann@gmail.com> <53A01049.6020502@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2014 12:01 PM, David Herrmann wrote: >> I don't think this is what potential users expect because mlock requires >> capabilities which are not available to them. >> >> A couple of weeks ago, sealing was to be applied to anonymous shared memory. >> Has this changed? Why should *reading* it trigger OOM? > > The file might have holes, therefore, you'd have to allocate backing > pages. This might hit a soft-limit and fail. To avoid this, use > fallocate() to allocate pages prior to mmap() This does not work because the consuming side does not know how the descriptor was set up if sealing does not imply that. > or mlock() to make the kernel lock them in memory. See above for why that does not work. I think you should eliminate the holes on sealing and report ENOMEM there if necessary. -- Florian Weimer / Red Hat Product Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/