Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756082AbaFQKyb (ORCPT ); Tue, 17 Jun 2014 06:54:31 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:36089 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756012AbaFQKy3 (ORCPT ); Tue, 17 Jun 2014 06:54:29 -0400 Message-ID: <53A01E61.3090600@imgtec.com> Date: Tue, 17 Jun 2014 11:54:25 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Daniel Borkmann , Guenter Roeck CC: "linux-kernel@vger.kernel.org" , "Linux MIPS Mailing List" , Ralf Baechle , Alexei Starovoitov Subject: Re: mips:allmodconfig build failure in 3.16-rc1 due to bpf_jit code References: <539FA6CB.5050703@roeck-us.net> <539FFA6B.9030004@redhat.com> <53A01572.5090603@redhat.com> In-Reply-To: <53A01572.5090603@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2014 11:16 AM, Daniel Borkmann wrote: > On 06/17/2014 10:20 AM, Daniel Borkmann wrote: >> On 06/17/2014 04:24 AM, Guenter Roeck wrote: >>> mips:allmodconfig fails in 3.16-rc1 with lots of undefined symbols. >>> >>> arch/mips/net/bpf_jit.c: In function 'is_load_to_a': >>> arch/mips/net/bpf_jit.c:559:7: error: 'BPF_S_LD_W_LEN' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:559:7: note: each undeclared identifier is >>> reported only once for each function it appears in >>> arch/mips/net/bpf_jit.c:560:7: error: 'BPF_S_LD_W_ABS' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:561:7: error: 'BPF_S_LD_H_ABS' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:562:7: error: 'BPF_S_LD_B_ABS' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:563:7: error: 'BPF_S_ANC_CPU' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:564:7: error: 'BPF_S_ANC_IFINDEX' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:565:7: error: 'BPF_S_ANC_MARK' undeclared >>> (first use in this function) >>> >>> and so on. >>> >>> Those symbols are not defined anywhere. >>> >>> The problem is due to a conflict with commit 348059313 (net: filter: >>> get rid of BPF_S_* >>> enum), which removed those definitions. >> >> Yep, it seems both got in this merge window from different trees. >> Don't have mips, but >> I'll have a look, and send you a patch. > > Could you give the attached patch a try? > > Thanks, > > Daniel Hi Daniel, This fixes the build and seems to work ok (tried with dhcp and tcpdump). Thanks for fixing it. Reviewed-by: Markos Chandras Tested-by: Markos Chandras -- markos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/