MIME-version: 1.0
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 8BIT
Message-id: <53A0256A.2000904@samsung.com>
Date: Tue, 17 Jun 2014 13:24:26 +0200
From: Marek Szyprowski <m.szyprowski@samsung.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101
 Thunderbird/24.6.0
To: Tushar Behera <tushar.b@samsung.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Cc: gregkh@linuxfoundation.org, trblinux@gmail.com
Subject: Re: [PATCH] usb: misc: usb3503: Update error code in print message
References: <1403003330-17553-1-git-send-email-tushar.b@samsung.com>
In-reply-to: <1403003330-17553-1-git-send-email-tushar.b@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org

Hello,

On 2014-06-17 13:08, Tushar Behera wrote:
> 'err' is uninitialized, rather print the error code directly.
>
> This also fixes following warning.
> drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
> drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized
> in this function [-Wmaybe-uninitialized]
>      dev_err(dev, "unable to request refclk (%d)\n", err);
>
> Signed-off-by: Tushar Behera <tushar.b@samsung.com>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>
> Based on next-20140616.
>
>   drivers/usb/misc/usb3503.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
> index f43c619..652855b 100644
> --- a/drivers/usb/misc/usb3503.c
> +++ b/drivers/usb/misc/usb3503.c
> @@ -192,7 +192,8 @@ static int usb3503_probe(struct usb3503 *hub)
>   
>   		clk = devm_clk_get(dev, "refclk");
>   		if (IS_ERR(clk) && PTR_ERR(clk) != -ENOENT) {
> -			dev_err(dev, "unable to request refclk (%d)\n", err);
> +			dev_err(dev, "unable to request refclk (%ld)\n",
> +					PTR_ERR(clk));
>   			return PTR_ERR(clk);
>   		}
>   

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/