Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932925AbaFQM3b (ORCPT ); Tue, 17 Jun 2014 08:29:31 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:49352 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932209AbaFQM33 (ORCPT ); Tue, 17 Jun 2014 08:29:29 -0400 Message-ID: <53A03471.3070007@ti.com> Date: Tue, 17 Jun 2014 17:58:33 +0530 From: George Cherian User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Guenter Roeck , , , , , , , , , CC: , , Subject: Re: [PATCH] extcon: extcon-dra7xx: Add Extcon driver for DRA7xx References: <1402886548-22765-1-git-send-email-george.cherian@ti.com> <539E79A1.50208@roeck-us.net> <539E8399.80902@ti.com> <539EFC15.8000304@roeck-us.net> In-Reply-To: <539EFC15.8000304@roeck-us.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/2014 7:45 PM, Guenter Roeck wrote: > On 06/15/2014 10:41 PM, George Cherian wrote: >> On 6/16/2014 10:29 AM, Guenter Roeck wrote: >>> On 06/15/2014 07:42 PM, George Cherian wrote: >>>> This is the driver for the USB ID pin detection. This driver >>>> handles only the USB ID pin changes generated by cable >>>> insertion/removal. >>>> >>>> Signed-off-by: George Cherian >>> >>> Hi George, >>> >>> Curious: Why can't you use extcon-gpio ? >> Main reason being missing dt support. > > Then why not add dt support to it ? Yes, I did sent a patch for the same. http://marc.info/?l=linux-kernel&m=140297766828100&w=2 http://marc.info/?l=linux-kernel&m=140297771028124&w=2 http://marc.info/?l=linux-kernel&m=140297768828109&w=2 > >>> >>> Also, I thought that Linux specific bindings would be unacceptable. >>> "ti,dra7xx-extcon" looks very linux specific to me. Did the rules >>> change ? >>> >> Then how about "ti,extcon-usbid" ? > > "extcon" seems very linux specific to me. > > Anyway, not arguing, just asking, since I wondered. If the extcon > maintainer > and the dt folks are happy with your driver, so am I. > > Guenter > -- -George -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/