Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932862AbaFQOAT (ORCPT ); Tue, 17 Jun 2014 10:00:19 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:53137 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932133AbaFQOAS (ORCPT ); Tue, 17 Jun 2014 10:00:18 -0400 X-Greylist: delayed 454 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 Jun 2014 10:00:18 EDT From: "Steve Wise" To: "'David Rientjes'" , "'Nick Krause'" Cc: , , , , , References: <1402940957-6381-1-git-send-email-xerofoify@gmail.com> <539F34E8.3000501@opengridcomputing.com> In-Reply-To: Subject: RE: [PATCH] infiniband: Fixes memory leak in send_flowc Date: Tue, 17 Jun 2014 08:53:01 -0500 Message-ID: <002201cf8a33$740fc730$5c2f5590$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQCl4K9OGHsDmNxTUoFf1Os0BPv3BQIL7OVvAvWTOKMBz17rRwKHZ9TnAfVsOhYCaUrVAJ1a7Vyw Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-owner@vger.kernel.org] On > Behalf Of David Rientjes > Sent: Monday, June 16, 2014 7:37 PM > To: Nick Krause > Cc: Steve Wise; swise@chelsio.com; roland@kernel.org; sean.hefty@intel.com; > hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] infiniband: Fixes memory leak in send_flowc > > On Mon, 16 Jun 2014, Nick Krause wrote: > > > That's true David, > > I will resend this parch without the use of the pr_warn. > > There's no patch to resend if you don't use pr_warn(). kfree_skb(skb) is > unnecessary if !skb, look at the first thing it checks: > > void kfree_skb(struct sk_buff *skb) > { > if (unlikely(!skb)) > return; > ... > } > > Thus, I don't see the memory leak you're referring to. send_flowc() still needs to handle a NULL return from get_skb(). That is what the bug report is addressing... Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/