Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933056AbaFQOTs (ORCPT ); Tue, 17 Jun 2014 10:19:48 -0400 Received: from forward18.mail.yandex.net ([95.108.253.143]:48505 "EHLO forward18.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932915AbaFQOTr (ORCPT ); Tue, 17 Jun 2014 10:19:47 -0400 From: Kirill Tkhai To: Thomas Gleixner Cc: "linux-kernel@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Sebastian Andrzej Siewior , Paul Gortmaker , Mike Galbraith In-Reply-To: <1401396751.1628.4.camel@localhost.localdomain> References: <5362122B.8060305@yandex.ru> <1399314660.6978.3.camel@localhost.localdomain> <1401396751.1628.4.camel@localhost.localdomain> Subject: Re: [RFC] rtmutex: Do not boost fair tasks each other MIME-Version: 1.0 Message-Id: <4717441403014772@web18g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 17 Jun 2014 18:19:32 +0400 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thomas, have you seen this version? Thanks, Kirill 30.05.2014, 00:52, "Kirill Tkhai" : > ? ??, 28/05/2014 ? 22:26 +0200, Thomas Gleixner ?????: >> ?On Mon, 5 May 2014, Kirill Tkhai wrote: >>> ?? ??, 03/05/2014 ? 20:54 +0200, Thomas Gleixner ?????: >>>> ?Though exercising that code path as much as we can is not a bad thing >>>> ?either. So I'd like to see that made compile time conditional on one >>>> ?of the lock testing CONFIG items. >>> ?+#ifndef CONFIG_RT_MUTEX_BOOST_ALL >> ?No, not another pointless config option. Read what I said. What's >> ?wrong with using an existing config item, e.g DEBUG_RT_MUTEXES? >>> ?+#define heritable_prio(prio) (rt_prio(prio) || dl_prio(prio)) >> ?inheritable please. It's not priority heritance and never will be. > > Thanks for comments. Here is new version. > > [PATCH] rtmutex: Do not boost owner's prio if waiter is SCHED_OTHER > > Higher priority does not provide exclusive privilege > of one fair class task over the other. In this case > priority boosting is pointless, and it may worsen > performance. > > This patch makes boosting, which is requested by fair > class waiters, optional. It's disabled by default, but > it's possible to enable it for debugging purposes to > have more cases of priority inheritance. > > Signed-off-by: Kirill Tkhai > > ?kernel/locking/rtmutex.c | 28 +++++++++++++++++++++------- > ?1 file changed, 21 insertions(+), 7 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/